Add Active Message receiver callbacks #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
breaking
|
@mdemoret-nv FYI |
Any non-const container that may have an external reference (such as a `std::string_view`) may change its underlying content and invalidate hashing, thus we must ensure the value can't change once registered.
wence-
approved these changes
Mar 14, 2024
cpp/src/internal/request_am.cpp
Outdated
Comment on lines
35
to
41
| if (_receiverCallback) { | ||
| _request->_callback = [this](ucs_status_t, std::shared_ptr<void>) { | ||
| _receiverCallback(_request); | ||
| }; | ||
| } | ||
|
|
||
| _request->callback(request, status); |
There was a problem hiding this comment.
Does it make more sense to do this rewriting on the _request in the constructor, rather than the callback? That way you wouldn't even need the _receiverCallback slot I think
cpp/src/request_am.cpp
Outdated
Comment on lines
76
to
78
|
|
||
| memcpy(serialized.data() + offset, &memoryType, sizeof(memoryType)); | ||
| offset += sizeof(memoryType); |
There was a problem hiding this comment.
Very minor polish, perhaps unnecessary:
auto encode = [&offset, &serialized](void const *data, size_t bytes) {
memcpy(serialized.data() + offset, data, bytes);
offset += bytes;
}
And then:
encode(&memoryType, sizeof(memoryType));
encode(&hasReceiverCallback, sizeof(hasReceiverCallback));
if (hasReceiveCallback) {
encode(&ownerSize, sizeof(ownerSize));
encode(receiverCallbackInfo->owner.c_str(), ownerSize);
encode(&receiverCallbackInfo->id, sizeof(receiverCallbackInfo->id));
}
And something matching on the decode side.
There was a problem hiding this comment.
That's an excellent idea! Done in 1920ff1 .
cpp/src/request_am.cpp
Outdated
| auto allocatorType = *static_cast<const ucs_memory_type_t*>(header); | ||
| // auto amHeader = AmHeader::deserialize(static_cast<const char*>(header)); | ||
| auto amHeader = | ||
| AmHeader::deserialize(std::string(static_cast<const char*>(header), header_length)); |
There was a problem hiding this comment.
This copies the header, suggestion:
Suggested change
| AmHeader::deserialize(std::string(static_cast<const char*>(header), header_length)); | |
| AmHeader::deserialize(std::string_view(static_cast<const char*>(header), header_length)); |
And accept a std::string_view in deserialize.
|
Thanks @wence- for reviewing! |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new pattern to receive Active Messages where the receiving endpoint registers a callback and the sender informs receiver of the callback to use, the receiver then executes that callback and does not require an explicit
ep->amRecv()call.Sample code:
This PR only implements C++ parts, #187 tracks the missing Python implementation.